Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

592 playback session manager #597

Merged
merged 7 commits into from
Jun 24, 2024
Merged

592 playback session manager #597

merged 7 commits into from
Jun 24, 2024

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

The goal of this PR is to provide a tool to track current sessions. Session can be started before the player is playing it. For example when the next media item is loaded.

Changes made

  • Add PlaybackSessionManager to handle session.
  • Debug implementation is also provided in PillarboxExoPlayer.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

Code Coverage

Overall Project 53.34% -0.13% 🟢
Files changed 94.5% 🟢

Module Coverage
:pillarbox-player 55.14% -0.25% 🟢
Files
Module File Coverage
:pillarbox-player PlaybackSessionManager.kt 93.81% -6.19% 🟢
PillarboxExoPlayer.kt 84.45% 🟢

@MGaetan89 MGaetan89 linked an issue Jun 20, 2024 that may be closed by this pull request
Playback session manager #592
Closed
MGaetan89
MGaetan89 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed some comment rewording, and left some questions. Otherwise, this looks good to me.

pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/analytics/PlaybackSessionManager.kt Outdated Show resolved Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/analytics/PlaybackSessionManager.kt Outdated Show resolved Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/analytics/PlaybackSessionManager.kt Outdated Show resolved Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/analytics/PlaybackSessionManager.kt Outdated Show resolved Hide resolved
@StaehliJ StaehliJ force-pushed the 592-playback-session-manager branch from b76166a to 1234e66 Compare June 24, 2024 06:42
@StaehliJ
Revert "wip"
0206e3f 
This reverts commit 4be9fa6.

# Conflicts:
#	pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/PillarboxExoPlayer.kt
@MGaetan89 MGaetan89 merged commit 0b6a850 into qos Jun 24, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the 592-playback-session-manager branch June 24, 2024 07:04
StaehliJ added a commit that referenced this pull request Jun 26, 2024
@StaehliJ @MGaetan89
592 playback session manager (#597)
2f24391 
Co-authored-by: Gaëtan Muller <[email protected]>
@MGaetan89 MGaetan89 mentioned this pull request Jun 26, 2024
Merged
6 tasks
MGaetan89 added a commit that referenced this pull request Jul 9, 2024
@StaehliJ @MGaetan89
592 playback session manager (#597)
519c9b4 
Co-authored-by: Gaëtan Muller <[email protected]>
MGaetan89 added a commit that referenced this pull request Jul 11, 2024
@StaehliJ @MGaetan89
592 playback session manager (#597)
571e371 
Co-authored-by: Gaëtan Muller <[email protected]>
MGaetan89 added a commit that referenced this pull request Jul 17, 2024
@StaehliJ @MGaetan89
592 playback session manager (#597)
de5a697 
Co-authored-by: Gaëtan Muller <[email protected]>
MGaetan89 added a commit that referenced this pull request Jul 29, 2024
@StaehliJ @MGaetan89
592 playback session manager (#597)
2f2618d 
Co-authored-by: Gaëtan Muller <[email protected]>
MGaetan89 added a commit that referenced this pull request Jul 30, 2024
@StaehliJ @MGaetan89
592 playback session manager (#597)
0826209 
Co-authored-by: Gaëtan Muller <[email protected]>
MGaetan89 added a commit that referenced this pull request Aug 12, 2024
@StaehliJ @MGaetan89
592 playback session manager (#597)
a7b95f8 
Co-authored-by: Gaëtan Muller <[email protected]>
MGaetan89 added a commit that referenced this pull request Aug 13, 2024
@StaehliJ @MGaetan89
592 playback session manager (#597)
a70ec50 
Co-authored-by: Gaëtan Muller <[email protected]>
MGaetan89 added a commit that referenced this pull request Aug 20, 2024
@StaehliJ @MGaetan89
592 playback session manager (#597)
6cbef51 
Co-authored-by: Gaëtan Muller <[email protected]>
StaehliJ added a commit that referenced this pull request Aug 28, 2024
@StaehliJ @MGaetan89
592 playback session manager (#597)
16b1bd9 
Co-authored-by: Gaëtan Muller <[email protected]>
StaehliJ added a commit that referenced this pull request Sep 11, 2024
@StaehliJ @MGaetan89
592 playback session manager (#597)
21ff81d 
Co-authored-by: Gaëtan Muller <[email protected]>
MGaetan89 added a commit that referenced this pull request Sep 12, 2024
@StaehliJ @MGaetan89
592 playback session manager (#597)
b759454 
Co-authored-by: Gaëtan Muller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playback session manager
2 participants
@StaehliJ @MGaetan89