Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: use runUntilPendingCommandsAreFullyHandled in CommandersActTrackerIntegrationTest #603

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Fix: use runUntilPendingCommandsAreFullyHandled in CommandersActTrackerIntegrationTest #603

merged 2 commits into from
Jun 25, 2024

Conversation

MGaetan89
Copy link
Member

Pull request

Description

This commit replaces playUntilStartOfMediaItem with årunUntilPendingCommandsAreFullyHandled in the CommandersActTrackerIntegrationTest file.

Changes made

  • Switch from playUntilStartOfMediaItem to runUntilPendingCommandsAreFullyHandled in CommandersActTrackerIntegrationTest.
  • Try to enable two @Ignored tests in ComScoreTrackerIntegrationTest.

Note

This cherry-picks #598 into main.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

MGaetan89 added 2 commits June 24, 2024 13:47
@MGaetan89
Fix: use runUntilPendingCommandsAreFullyHandled in CommandersActTra…
b6e2fa0 
…ckerIntegrationTest

This commit replaces `playUntilStartOfMediaItem` with `run
UntilPendingCommandsAreFullyHandled` in the CommandersActTrackerIntegrationTest.
@MGaetan89
Enable ComScore integration tests for live content
5b94aca 
This commit removes the `@Ignore` annotations from the ComScore integration tests for live content, enabling them to run
 as part of the test suite. This assumes that a live DVR is now available outside of Switzerland for testing purposes.
@MGaetan89 MGaetan89 mentioned this pull request Jun 24, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 51.07% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 self-assigned this Jun 24, 2024
@MGaetan89 MGaetan89 enabled auto-merge June 24, 2024 14:30
@MGaetan89 MGaetan89 added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 778e487 Jun 25, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the fix_tests branch June 25, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

@MGaetan89 MGaetan89

Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGaetan89 @StaehliJ