-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Makefile targets #1104
Merged
Merged
Cleanup Makefile targets #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
waliid
force-pushed
the
1077-cleanup-makefile-targets
branch
from
December 15, 2024 12:30
f12a81b
to
0b4794e
Compare
waliid
force-pushed
the
1077-cleanup-makefile-targets
branch
from
December 15, 2024 12:38
0b4794e
to
5b0668b
Compare
defagos
reviewed
Jan 7, 2025
defagos
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two general comments which might already appear assigned to some code changes:
- Parameter management is likely better with
getopts
. Several parameters have been introduced an I think having a way to reliably manage them would be beneficial. - I like the idea of having extracted shell scripts for everything. I am still a bit wondering if we shouldn't make each script standalone. Some scripts have been introduced to factor out common logic (e.g. interactively getting secrets, installing pkgx, installing bundler) but shell scripts are difficult to read, understand and maintain when scattered over several files, each possibly defining its own set of variables used in other files.
defagos
reviewed
Jan 7, 2025
defagos
reviewed
Jan 7, 2025
defagos
approved these changes
Jan 7, 2025
defagos
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies our Makefile targets by using dedicated scripts for each one.
Changes made
public
andprivate
.public
directory are use by our Makefile.private
directory are use by our GitHub workflows.Checklist