Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Makefile targets #1104

Merged
merged 30 commits into from
Jan 7, 2025
Merged

Cleanup Makefile targets #1104

merged 30 commits into from
Jan 7, 2025

Conversation

waliid
Copy link
Member

@waliid waliid commented Dec 13, 2024

Description

This PR simplifies our Makefile targets by using dedicated scripts for each one.

Changes made

  • Scripts have been split in two directories, public and private.
    • Scripts located in public directory are use by our Makefile.
    • Scripts located in private directory are use by our GitHub workflows.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@waliid waliid linked an issue Dec 13, 2024 that may be closed by this pull request
4 tasks
@waliid waliid force-pushed the 1077-cleanup-makefile-targets branch from f12a81b to 0b4794e Compare December 15, 2024 12:30
@waliid waliid force-pushed the 1077-cleanup-makefile-targets branch from 0b4794e to 5b0668b Compare December 15, 2024 12:38
@waliid waliid marked this pull request as ready for review January 6, 2025 09:57
Scripts/test-streams.sh Outdated Show resolved Hide resolved
Copy link
Member

@defagos defagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two general comments which might already appear assigned to some code changes:

  • Parameter management is likely better with getopts. Several parameters have been introduced an I think having a way to reliably manage them would be beneficial.
  • I like the idea of having extracted shell scripts for everything. I am still a bit wondering if we shouldn't make each script standalone. Some scripts have been introduced to factor out common logic (e.g. interactively getting secrets, installing pkgx, installing bundler) but shell scripts are difficult to read, understand and maintain when scattered over several files, each possibly defining its own set of variables used in other files.

Scripts/fix-quality.sh Outdated Show resolved Hide resolved
Scripts/deliver-demo.sh Outdated Show resolved Hide resolved
Scripts/deliver-demo.sh Outdated Show resolved Hide resolved
Scripts/set-apple-api-env-interactively.sh Outdated Show resolved Hide resolved
Scripts/test.sh Outdated Show resolved Hide resolved
Scripts/find-dead-code.sh Outdated Show resolved Hide resolved
Scripts/clean-imports.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Scripts/public/git-hooks.sh Outdated Show resolved Hide resolved
@defagos defagos enabled auto-merge January 7, 2025 13:26
@defagos defagos added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 5115394 Jan 7, 2025
7 checks passed
@defagos defagos deleted the 1077-cleanup-makefile-targets branch January 7, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Cleanup Makefile targets
2 participants