Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support standard actions at item playback end #780

Merged
merged 17 commits into from
Feb 29, 2024

Conversation

waliid
Copy link
Member

@waliid waliid commented Feb 29, 2024

Description

This PR allows us to add a way to change the behavior of an item when it's ended.

Changes made

  • The property actionAtItemEnd has been introduced.
  • A new analytics session is created when an item is ended, even if it's paused.
  • The demo app has been updated:
    • The stories showcase is paused at the end.
    • An opt-in option has been added in the opt-in showcase.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@waliid waliid enabled auto-merge February 29, 2024 07:47
@waliid waliid added this pull request to the merge queue Feb 29, 2024
@defagos defagos linked an issue Feb 29, 2024 that may be closed by this pull request
5 tasks
Merged via the queue into main with commit 49b3c94 Feb 29, 2024
6 checks passed
@waliid waliid deleted the 745-support-standard-actions-at-item-playback-end branch February 29, 2024 08:34
@defagos defagos mentioned this pull request Mar 1, 2024
6 tasks
@defagos defagos mentioned this pull request Mar 1, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support standard actions at item playback end
2 participants