Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update pillarbox to the latest verison #11

Merged
merged 1 commit into from
May 27, 2024
Merged

chore: update pillarbox to the latest verison #11

merged 1 commit into from
May 27, 2024

Conversation

jboix
Copy link
Contributor

@jboix jboix commented Apr 29, 2024

Description

Updates pillarbox version to 1.12.0.

Changes Made

  • Removed the alias for @srgssr/pillarbox-web in the vitest configuration, as the package now includes an export clause in its package.json.

Checklist

  • I have followed the project's style and contribution guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.

@jboix
chore: update pillarbox to the latest verison
50df308 
- Removed the alias for @srgssr/pillarbox-web in the Vitest configuration,
  as the package now includes an export clause in its package.json.
@jboix jboix requested a review from amtins April 29, 2024 13:51
@jboix jboix self-assigned this Apr 29, 2024
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 89.78% 976 / 1087
🔵 Statements 89.78% 976 / 1087
🔵 Functions 92.3% 60 / 65
🔵 Branches 89.1% 90 / 101
File CoverageNo changed files found.
Generated in workflow #28

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-27 13:48 UTC

amtins
amtins approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jboix jboix added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit 2fd2892 May 27, 2024
4 checks passed
@jboix jboix deleted the chore/update-pillarbox branch May 27, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amtins amtins amtins approved these changes

Assignees

@jboix jboix

Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jboix @amtins