chore: add default media sources to theme editor input #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File CoverageNo changed files found. |
|
Resolve #9 by adding a pre-configured selection of default media sources to the theme editor's live preview section. The input field now includes a `datalist` element with default options for typical media scenarios. The `datalist` element was chosen to provide a simple and native solution for suggesting media sources, ensuring compatibility and ease of use across most browsers. While Firefox has limited support for the `datalist` element, the decision to use it was made to simplify the implementation and utilize native HTML5 elements when possible.
jboix
force-pushed
the
chore/default-sources
branch
from
d717d65 to
12cf4dd
Compare
defagos
reviewed
Jun 14, 2024
defagos
approved these changes
Jun 14, 2024
|
@jboix I see that this repository does not check that all discussions associated with a PR have been resolved before the PR can be merged. Shouldn't you enable this feature? |
@defagos we normally don't approve the PR if there are open discussion, I didn't even know that was a feature. Thanks for the feedback! |
Co-authored-by: Samuel Défago <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #9 by adding a pre-configured selection of default media sources to the theme editor's live preview section.
Changes Made
The input field now includes a
datalistelement with default options for typical media scenarios. Thedatalistelement was chosen to provide a simple and native solution for suggesting media sources, ensuring compatibility and ease of use across most browsers.While Firefox has limited support for the
datalistelement, the decision to use it was made to simplify the implementation and utilize native HTML5 elements when possible. See the compatibility chart: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/datalistSee the following comparison:
Checklist