Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview-box): default media URN #14

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix(preview-box): default media URN #14

merged 1 commit into from
Oct 7, 2024

Conversation

amtins
Copy link
Member

@amtins amtins commented Oct 1, 2024

Description

Change default value to avoid white background with BigPlayButton.

Changes Made

  • Use a URN with an appropriate background color and with subtitles

Checklist

  • I have followed the project's style and contribution guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.

Change default value to avoid white background with BigPlayButton.

- use a URN with an appropriate background color and with subtitles
@amtins amtins requested a review from jboix October 1, 2024 14:21
@amtins amtins added the bug Something isn't working label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 89.78% 976 / 1087
🔵 Statements 89.78% 976 / 1087
🔵 Functions 92.3% 60 / 65
🔵 Branches 89.1% 90 / 101
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/preview-box.js 100% 85.71% 100% 100%
Generated in workflow #36 for commit 7d7b811 by the Vitest Coverage Report Action

Copy link

github-actions bot commented Oct 1, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-07 09:04 UTC

@amtins amtins added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 281d93d Oct 7, 2024
4 checks passed
@amtins amtins deleted the fix/preloaded-media branch October 7, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants