Coverity CI changes: remove internal workflow and add 'covscan' label workflow for PRs #7698
Conversation
alexey-tikhonov
added
branch: sssd-2-9
branch: sssd-2-10
branch: sssd-2-9-4
justin-stephenson
force-pushed
the
coverity_use_label
branch
from
42c1038 to
10b9545
Compare
.github/workflows/coverity.yml
Outdated
| workflow_dispatch: | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
| jobs: | ||
| coverity: | ||
| coverity_daily: |
There was a problem hiding this comment.
Isn't this going to be run on each pull request?
There was a problem hiding this comment.
You are right, I missed that. I added if: ${{ github.event_name == 'schedule' }} to this job
There was a problem hiding this comment.
I think we can keep it as single job. Add a step that will get check the labels, if labels are not there and it is a pull request -> skip/cancel.
There was a problem hiding this comment.
I switched it to a single job with a multi-line if conditional:
+ if: |
+ ${{ github.event_name == 'schedule' }} ||
+ ${{ github.event.label.name == 'coverity' && github.event_name == 'pull_request' }}
.github/workflows/coverity.yml
Outdated
| # This job likely cannot be re-run on the same day or we will | ||
| # hit the build submission limit (see above link) | ||
| pull_request_target: | ||
| branches: [master] |
There was a problem hiding this comment.
shouldn't you narrow it down to
types:
- labeled
There was a problem hiding this comment.
It could be, do you suggest if someone wants to run covscan against their PR more than once they should just remove and re-add the label? If yes I will add a comment in this workflow about this.
There was a problem hiding this comment.
Yes. I think that current implementation will run covscan on each push if label is set, won't t? We need to trigger it only on desire. So either by setting the label or maybe by /covscan comment.
There was a problem hiding this comment.
Okay makes sense, I added the
types:
- labeled
889b617 to
d152355
Compare
.github/workflows/coverity.yml
Outdated
| workflow_dispatch: | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
| jobs: | ||
| coverity: | ||
| if: | | ||
| ${{ github.event_name == 'schedule' }} || | ||
| ${{ github.event.label.name == 'coverity' && github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
pull_request_target instead of pull_request?
justin-stephenson
force-pushed
the
coverity_use_label
branch
from
d152355 to
53123ef
Compare
|
Pushed PR: #7698
|
No description provided.