Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] launch / tag 기능 구현 #12

Merged
merged 3 commits into from
Sep 5, 2023
Merged

[FEAT] launch / tag 기능 구현 #12

merged 3 commits into from
Sep 5, 2023

Conversation

kikuke
Copy link
Contributor

@kikuke kikuke commented Aug 31, 2023

Issue

Description

  • Launch, Tag 기능 구현

Check List

  • PR 제목을 커밋 규칙에 맞게 작성
  • PR에 해당되는 Issue를 연결 완료
  • 적절한 라벨 설정
  • 작업한 사람 모두를 Assign
  • 작업한 팀에게 Code Review 요청 (Reviewer 등록)
  • main 브랜치의 최신 상태를 반영하고 있는지 확인

Screenshot

  • 필요한 경우에만 넣어주세요.

@kikuke kikuke self-assigned this Aug 31, 2023
@kikuke kikuke linked an issue Aug 31, 2023 that may be closed by this pull request
2 tasks
return getTagList(vol, doc);
}

private static TagList getTagList(int vol, Document doc) throws IOException {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static인 이유가 있을까요?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

삭제하시는걸로!

@kikuke kikuke merged commit 9773e53 into main Sep 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Launch, Tag 기능 구현
2 participants