Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ 108 query item template #131

Merged
merged 6 commits into from
Jun 26, 2023
Merged

✨ 108 query item template #131

merged 6 commits into from
Jun 26, 2023

Conversation

danielmackay
Copy link
Member

No description provided.

@danielmackay danielmackay linked an issue Jun 26, 2023 that may be closed by this pull request
📦 Query Item Template #108
Closed
@danielmackay
👷 Drop 'log4brains' slug from ADR site URL (#127)
2d32048 
* Remove log4brains slug from github pages url

* Remove target folder

* Revert workflow trigger changes
@danielmackay
📝 125 add ADR badge to readme (#128)
1c44c16 
* Added ADRs and tidied up readme

* Added ADR link into Log4Brains readme
@danielmackay
Merge branch 'main' into 108-query-item-template
29264e3
@danielmackay danielmackay marked this pull request as ready for review June 26, 2023 12:07
@danielmackay danielmackay enabled auto-merge (squash) June 26, 2023 12:14
@danielmackay danielmackay requested a review from a team June 26, 2023 23:00
matt-goldman
matt-goldman approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@matt-goldman matt-goldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome and definitely a feature of our template that others are missing!
I've added some comments for consideration but happy to approve as is.

README.md Show resolved Hide resolved
templates/query/.template.config/template.json Show resolved Hide resolved
@danielmackay danielmackay merged commit 83dd0f6 into main Jun 26, 2023
@danielmackay danielmackay deleted the 108-query-item-template branch June 26, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-goldman matt-goldman matt-goldman approved these changes

@william-liebenberg william-liebenberg Awaiting requested review from william-liebenberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📦 Query Item Template
2 participants
@danielmackay @matt-goldman