Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Refactored Domain to use a feature based approach #141

Merged
merged 1 commit into from
Jul 17, 2023
Merged

♻️ Refactored Domain to use a feature based approach #141

merged 1 commit into from
Jul 17, 2023

Conversation

danielmackay
Copy link
Member

No description provided.

@danielmackay danielmackay requested a review from a team July 17, 2023 12:59
@danielmackay danielmackay mentioned this pull request Jul 17, 2023
Closed
@danielmackay danielmackay enabled auto-merge (squash) July 17, 2023 13:01
@danielmackay danielmackay changed the title Refactored Domain to use a feature based approach ♻️ Refactored Domain to use a feature based approach Jul 17, 2023
@danielmackay
Copy link
Member Author

Before:
image

After:
image

@danielmackay
Copy link
Member Author

@william-liebenberg for a more compelling example here's what the same thing looks like in the CA workshop:
image

@danielmackay danielmackay merged commit dd2f194 into main Jul 17, 2023
4 checks passed
@danielmackay danielmackay deleted the 140-consider-grouping-domain-by-feature branch July 17, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-goldman matt-goldman matt-goldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmackay @matt-goldman