Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Update outdated and vulnerable packages #917

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

zacharykeeping
Copy link
Member

@zacharykeeping zacharykeeping commented Jun 20, 2024

  1. Updates many out of date packages, resolving every vulnerability from npm audit apart from a few in the API project that require more work to resolve.
  2. Updates HTMLHint and fixes breaking changes in its imports.
  3. Locks all versions of node to v20 (latest LTS) across the project as it's currently inconsistent and using different older versions.

The remaining vulnerabilities from the API project are related to a deprecated azure-storage package that requires migrating and refactoring to new packages. There's a PBI for this here: #918

Screenshot 2024-06-20 at 2 47 10 PM

❌ Figure: UI project previously had 9 vulnerabilities

Screenshot 2024-06-20 at 2 47 35 PM

❌ Figure: Docker project previously had 21 vulnerabilities

Screenshot 2024-06-20 at 2 44 26 PM

❌ Figure: API project previously had 24 vulnerabilities

Screenshot 2024-06-20 at 2 41 56 PM

✅ Figure: UI project now has 0 vulnerabilities

Screenshot 2024-06-20 at 2 42 16 PM

✅ Figure: Docker project now has 0 vulnerabilities

Screenshot 2024-06-20 at 2 42 49 PM

✅ Figure: API project now has 4 moderate vulnerabilities

@zacharykeeping zacharykeeping changed the base branch from main to staging June 20, 2024 04:39
@zacharykeeping zacharykeeping changed the title Update packages Update outdated and vulnerable packages Jun 20, 2024
@zacharykeeping zacharykeeping changed the title Update outdated and vulnerable packages ♻️ Update outdated and vulnerable packages Jun 20, 2024
@zacharykeeping zacharykeeping marked this pull request as ready for review June 20, 2024 05:00
@zacharykeeping zacharykeeping requested review from amankumarrr and removed request for william-liebenberg September 13, 2024 00:17
Copy link
Member

@amankumarrr amankumarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it is working with all the updates!

@zacharykeeping zacharykeeping merged commit 73c3b97 into staging Sep 13, 2024
4 checks passed
@zacharykeeping zacharykeeping deleted the update-packages branch September 13, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants