Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Custom Link Element Prop #72

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Add Custom Link Element Prop #72

merged 4 commits into from
Feb 14, 2024

Conversation

Harry-Ross
Copy link
Contributor

Fixes #59

  • Added context-provided link component so that Next.js and Gatsby link components can be used instead of a base <a> tag

@Harry-Ross Harry-Ross assigned JackDevAU and unassigned JackDevAU Feb 13, 2024
amankumarrr
amankumarrr approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@amankumarrr amankumarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Harry-Ross Harry-Ross merged commit 17f4fe7 into main Feb 14, 2024
1 check passed
@Harry-Ross Harry-Ross deleted the add-custom-link-element branch February 14, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amankumarrr amankumarrr amankumarrr approved these changes

@BrookJeynes BrookJeynes Awaiting requested review from BrookJeynes

@JackDevAU JackDevAU Awaiting requested review from JackDevAU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Megamenu links always use anchors instead of client side routing
3 participants
@Harry-Ross @amankumarrr @JackDevAU