Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed people filters breaking in staging #645

Merged

Conversation

Calinator444
Copy link
Member

@Calinator444 Calinator444 commented Jul 10, 2024

Description

Fixed search criteria breaking in staging. The Issue turned out to be that attempting to load application insights with a missing key would cause the program to crash.

If ApplicationInsights key is empty, we'll get this log warning:
image

Otherwise, it will display console error:

console.error('Error initializing Application Insights', error);

…ters' of https://github.com/SSWConsulting/SSW.People into 622--deployments-change-from-vm-to-blob-storage-fix-filters
Copy link
Member

@wicksipedia wicksipedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Calinator444 Calinator444 changed the title added logging to see if filter method is being clicked 🐛 Fixed people filters breaking in staging Jul 10, 2024
@Calinator444 Calinator444 merged commit 6a86cd3 into main Jul 10, 2024
8 checks passed
@Calinator444 Calinator444 deleted the 622--deployments-change-from-vm-to-blob-storage-fix-filters branch July 10, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Deployments - change from VM to Blob storage
3 participants