Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 API | Fix network query #1023

Merged
merged 4 commits into from
Sep 4, 2024
Merged

🐛 API | Fix network query #1023

merged 4 commits into from
Sep 4, 2024

Conversation

zacharykeeping
Copy link
Member

@zacharykeeping zacharykeeping commented Sep 2, 2024

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Closes #1026

  1. What was changed?

Currently the Network tab is returning incorrect data and crashing when tapping a user as the user ID isn't returned.

This fixes those issues by updating the query and making sure the ID is returned. Also fixes the Activity feed to use the correct Friends feed.

  1. Did you do pair or mob programming?

No

Copy link
Member

@JackDevAU JackDevAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@zacharykeeping zacharykeeping merged commit baf5575 into main Sep 4, 2024
6 checks passed
@zacharykeeping zacharykeeping deleted the fix-network branch September 4, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 API | Network tab showing incorrect data and crashing
2 participants