Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Mobile | Add deep linking #1050

Merged
merged 6 commits into from
Sep 19, 2024
Merged

✨ Mobile | Add deep linking #1050

merged 6 commits into from
Sep 19, 2024

Conversation

zacharykeeping
Copy link
Member

@zacharykeeping zacharykeeping commented Sep 18, 2024 •
edited
Loading

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Closes #321

  1. What was changed?
  1. Adds an "sswrewards://" custom URL scheme to allow invoking and communicating with the app directly.
  2. Handles receiving QR codes via a link in the format of "sswrewards://redeem?code={{code}}".
  3. Prepends this new URL scheme when rendering existing codes
  1. Did you do pair or mob programming?

No

@zacharykeeping
Merge branch 'main' into deep-linking
4d5a940 
# Conflicts:
#	src/MobileUI/Platforms/Android/MainActivity.cs
@zacharykeeping
Cleanup
1005314
matt-goldman-ssw
matt-goldman-ssw approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@matt-goldman-ssw matt-goldman-ssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one suggestion, you can add it as a PBI if you don't want to commit that change now.

src/MobileUI/MauiProgram.cs
{
ios.OpenUrl((app, url, options) => HandleAppLink(url.AbsoluteString));
});
#else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#else
#else if ANDROID

@zacharykeeping zacharykeeping merged commit ddff5de into main Sep 19, 2024
6 checks passed
@zacharykeeping zacharykeeping deleted the deep-linking branch September 19, 2024 07:16
@zacharykeeping zacharykeeping mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-goldman-ssw matt-goldman-ssw matt-goldman-ssw approved these changes

@tkapa tkapa Awaiting requested review from tkapa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Mobile | Add deep linking
2 participants
@zacharykeeping @matt-goldman-ssw