Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeddings Refresher #169

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Embeddings Refresher #169

merged 6 commits into from
Jul 16, 2024

Conversation

calumjs
Copy link
Member

@calumjs calumjs commented Jul 16, 2024

Adding an Azure Function which will grab rule markdown file changes in the specified time period, embed and upsert to the vector database.

Temporarily deploying as HTTP trigger so I can test it a bit, once happy will convert to timer trigger and forget about it.

Related to #48

@calumjs calumjs requested a review from bradystroud July 16, 2024 00:30
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment, looks good otherwise

.github/workflows/template-build-deploy.yml Outdated Show resolved Hide resolved
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛶

@calumjs calumjs merged commit eb50991 into main Jul 16, 2024
@calumjs calumjs deleted the feature/embeddings-refresher branch July 16, 2024 04:10
resource hostingPlan 'Microsoft.Web/serverfarms@2021-03-01' existing = {
name: hostingPlanName
scope: resourceGroup(hostingPlanRgName)
}

resource kv 'Microsoft.KeyVault/vaults@2023-07-01' = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this KV version changed to use an older version? @calumjs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
When I tried to build it locally during testing I got a bunch of warnings, so I just swapped it to a value from another pipeline.
Did I miss something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok I see - I just had an old version of bicep installed - no warning after upgrade.
Will put it back to the 2023 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants