-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💡 Added logic to remove whitespace from the line #1519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babakamyljanovssw
had a problem deploying
to
staging
September 30, 2024 08:54
— with
GitHub Actions
Failure
3 tasks
babakamyljanovssw
temporarily deployed
to
staging
September 30, 2024 09:00
— with
GitHub Actions
Inactive
babakamyljanovssw
temporarily deployed
to
staging
September 30, 2024 09:06
— with
GitHub Actions
Inactive
This PR is awesome I know the fix was super simple, but i think its worth making a Done Video since it could help other people
|
2 tasks
babakamyljanovssw
temporarily deployed
to
staging
October 8, 2024 03:23
— with
GitHub Actions
Inactive
Hi @bradystroud ✅ All done Issue on gatsby repo - gatsbyjs/gatsby#39136 |
babakamyljanovssw
temporarily deployed
to
staging
October 8, 2024 03:28
— with
GitHub Actions
Inactive
bradystroud
previously approved these changes
Oct 8, 2024
Co-authored-by: Brady Stroud [SSW] <[email protected]>
babakamyljanovssw
temporarily deployed
to
staging
October 8, 2024 03:47
— with
GitHub Actions
Inactive
bradystroud
approved these changes
Oct 8, 2024
babakamyljanovssw
had a problem deploying
to
staging
October 8, 2024 03:52
— with
GitHub Actions
Error
babakamyljanovssw
temporarily deployed
to
staging
October 8, 2024 04:08
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @bradystroud @Calinator444 @tkapa @BrookJeynes
Relates to #1448
Added logic to
gatsby-node.js
to remove whitespace from lines that contains only whitespace.Then tested
yarn build
with new logic and without it.For testing created
test-sample-content
branch in content repo, and added intentional whitespace to the rule.Figure: Line 67 contains a whitespace
As result:
Figure: Build fails without new logic
🤖 Copilot's summary
This pull request includes changes to the
gatsby-node.js
file to improve the handling of Markdown content and streamline the code.Content handling improvements:
gatsby-node.js
: Added logic to trim empty lines from the Markdown content before processing. This ensures that unnecessary whitespace is removed, leading to cleaner content handling.Codebase simplification:
gatsby-node.js
: Added a new line after theonCreateNode
function for better readability and separation of concerns.