Small corrections #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this one I'm not sure but it looks better than it was
it looks like these are used elsewhere when there's a comma in the function description
DavidIB
added a commit
that referenced
this pull request
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've tried to correct some small inconsistencies that I noticed while using this data – please do let me know if anything isn't quite right.
Details
In particular it would be good to check the places where I've added the parsing in TEGMC (once for
PRT, and twice towards the bottom of the file forV-RMP-...).With the bottom two, I wasn't totally sure if the description of the function was complete as the end of the line looked suspect, e.g.:
https://github.com/tyndale/STEPBible-Data/blob/db6d82b0c520c8c82dbdba13a820e113bb3b94e3/TEGMC%20-%20Tyndale%20Expansion%20of%20Greek%20Morphhology%20Codes%20-%20STEPBible.org%20CC%20BY.txt#L7554
I've made this as a pull request for ease of merging, and could squash it into a single
'various fixes'commit if that helps.