Added record_metadata_fields_to_span macro to common crate #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modularius
changed the title
|
On it's own this isn't really an atomic PR. What calls |
|
As with the other PR I was going to add the callers in the other crates later, but it makes sense to add them in here wherever possible. |
DanNixon
requested changes
Aug 30, 2024
…record_metadata_fields_to_span-macro
DanNixon
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Added
record_metadata_fields_to_spanmacro to populate spans which are setup to record metadata fields.Instruction for review/testing
Does code reflect description above, and does the attached doc comment make sense and adequately explain its purpose.