-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve simulator functionality #249
Improve simulator functionality #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the amount of unwrap
and expect
. Now that we have a standard for how error handling should happen I would like new and refactored code to use it (arguably it is of less concern for the simulator but I see a lot of the same elsewhere, anything related to tracing for example).
There were considerably more |
See https://github.com/STFC-ICD-Research-and-Design/supermusr-data-pipeline/blob/main/docs/style.md#crab-error-handling-rules, |
Summary of changes
unwrap
s toexpect
s inbuild_messages.rs
send_trace_message
tosend_digitiser_trace_message
and integrated edits insend_messages.rs
,simulation.rs
,engine.rs
and others.Trace
struct for channel traces inevent_lists.rs
and refactoredIntConstant
andTextConstant
typesEnsureDelayMs
actionInstruction for review/testing
General code review as the simulator was successfully tested in the pipeline.