Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fields to Nexus Writer spans #250

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Add fields to Nexus Writer spans #250

merged 1 commit into from
Sep 11, 2024

Conversation

Modularius
Copy link
Contributor

Summary of changes

  1. Added required fields to spans of Nexus Writer crate.
  2. Implemented required error handling.

Instruction for review/testing

Do the spans conform to the required OpenTelemetry standard?

@Modularius Modularius requested a review from DanNixon September 6, 2024 11:19
@Modularius Modularius changed the title Add fields to spans Add fields to Nexus Writer spans Sep 11, 2024
@DanNixon DanNixon merged commit f5dcc53 into STFC-ICD-Research-and-Design:main Sep 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanNixon DanNixon DanNixon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Super-MuSR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Modularius @DanNixon