Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored functions in main.rs and added fields to spans #251

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Refactored functions in main.rs and added fields to spans #251

merged 1 commit into from
Sep 10, 2024

Conversation

Modularius
Copy link
Contributor

Summary of changes

  1. Refactored main loop into functions process_kafka_message and process_digitiser_trace_message
  2. Added metadata and digitiser id fields to instrumented spans of the above functions and functions in processing.rs.

Instruction for review/testing

Are changes as described above?

@Modularius Modularius requested a review from DanNixon September 9, 2024 08:24
@DanNixon DanNixon merged commit 8125096 into STFC-ICD-Research-and-Design:main Sep 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanNixon DanNixon DanNixon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Super-MuSR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Modularius @DanNixon