Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic refactoring #259

Merged

Conversation

Modularius
Copy link
Contributor

Summary of changes

  1. General refactoring to make code more idiomatic
  2. Moved the constructor and display functionality of DigitiserData to its own file.
  3. Reworked the column structure to group up related items (as described in the README).
  4. Added weights options to the column widths, making some columns larger than others.
  5. Introduced Channel column which monitors a single channel (adjustable with left/right keys) and displays channel id and sample range.

Instruction for review/testing

General code review.
Test with command such as

cargo run --bin diagnostics daq-trace --broker 130.246.55.29:9092 --topic daq-traces-in --group vis-3

when a run is in progress from the chosen broker.

@Modularius Modularius requested a review from DanNixon October 2, 2024 10:12
Copy link
Member

@DanNixon DanNixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DanNixon DanNixon merged commit 092bd85 into STFC-ICD-Research-and-Design:main Oct 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants