-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container Image Builds. #71
Container Image Builds. #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just occurred to me that we still need the observability address set in cases that an observability endpoint is present, this is indicated by the observability address being a command line option.
In the case they are, the observability address environment variable should be set.
In the case they are not, the observability address variable is not required, nor in the ExposedPorts
.
The last thing to do is to remove any left over Containerfile
s and .containerignore
.
(to keep track of the images I have tested so far):
|
@Henry-Denny Looks like there are conflicts that need fixed here. |
594fb61
to
3d1f66e
Compare
Closes #65.