Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Image Builds. #71

Merged

Conversation

Henry-Denny
Copy link
Member

Closes #65.

Copy link
Member

@DanNixon DanNixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just occurred to me that we still need the observability address set in cases that an observability endpoint is present, this is indicated by the observability address being a command line option.

In the case they are, the observability address environment variable should be set.

In the case they are not, the observability address variable is not required, nor in the ExposedPorts.

The last thing to do is to remove any left over Containerfiles and .containerignore.

.github/workflows/container_image.yml Outdated Show resolved Hide resolved
@Henry-Denny Henry-Denny requested a review from DanNixon October 17, 2023 15:13
@DanNixon
Copy link
Member

DanNixon commented Oct 18, 2023

(to keep track of the images I have tested so far):

  • events-to-histogram-container-image: package 'docker-image-events-to-histogram.tar.gz'
  • kafka-daq-report-container-image: package 'docker-image-kafka-daq-report.tar.gz'
  • simulator-container-image: package 'docker-image-simulator.tar.gz'
  • stream-to-file-container-image: package 'docker-image-stream-to-file.tar.gz'
  • trace-archiver-container-image: package 'docker-image-trace-archiver.tar.gz'
  • trace-to-events-container-image: package 'docker-image-trace-to-events.tar.gz'

@DanNixon
Copy link
Member

@Henry-Denny Looks like there are conflicts that need fixed here.

@DanNixon DanNixon force-pushed the container-image-builds branch from 594fb61 to 3d1f66e Compare October 20, 2023 10:16
@DanNixon DanNixon merged commit 0dc4039 into STFC-ICD-Research-and-Design:main Oct 20, 2023
7 checks passed
@Henry-Denny Henry-Denny deleted the container-image-builds branch October 20, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container image builds
2 participants