-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace to events #80
Trace to events #80
Conversation
Is there no way this PR can be split up? 7k lines is way too big for a single PR. |
Yes, I can submit the trace-to-pulses crate separately. |
A few things that would form a starting point of making this more reviewable:
|
That will not really help, that crate is the vast majority of the code in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An initial look over. There are more places with style issues that I did not comment on.
Closes #49