Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit Dependencies #91

Merged
merged 15 commits into from
Dec 4, 2023
Merged

Inherit Dependencies #91

merged 15 commits into from
Dec 4, 2023

Conversation

Henry-Denny
Copy link
Member

The common and streaming-types dependencies are now inherited from the main Cargo.toml file.

DanNixon
DanNixon requested changes Nov 30, 2023
View reviewed changes
Copy link
Member

@DanNixon DanNixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also some crates that still have dependency versions in their Cargo.toml.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Henry-Denny and others added 4 commits November 30, 2023 12:27
@Henry-Denny
Copy link
Member Author

There are also some crates that still have dependency versions in their Cargo.toml.

Are you referring to the crates that are only included in one place like itertools?

@DanNixon
Copy link
Member

There are also some crates that still have dependency versions in their Cargo.toml.

Are you referring to the crates that are only included in one place like itertools?

Yes.

@Henry-Denny Henry-Denny requested a review from DanNixon December 4, 2023 10:17
DanNixon
DanNixon requested changes Dec 4, 2023
View reviewed changes
docs/style.md Outdated Show resolved Hide resolved
DanNixon
DanNixon requested changes Dec 4, 2023
View reviewed changes
docs/style.md Show resolved Hide resolved
DanNixon
DanNixon approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@DanNixon DanNixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DanNixon DanNixon merged commit 68560d8 into STFC-ICD-Research-and-Design:main Dec 4, 2023
9 checks passed
@Henry-Denny Henry-Denny deleted the inherit-dependencies branch December 7, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanNixon DanNixon DanNixon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Henry-Denny @DanNixon