FIX crash when nofilter & compat is false #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, than you for this lib, it's very useful for me. I've found a crash when somebody sets as option compat: false and doesn't specify defaultFilterRole or specify 'nofilter'.
As we can see on filter.js file, _getFilterKeys method:
var filter = {nofilter: null};
nofilter value is null, for that reason it crashes later on getReadFilterKeys method when:
filters.join(' ');