Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX crash when nofilter & compat is false #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ericzon
Copy link

@ericzon ericzon commented Mar 21, 2017

First of all, than you for this lib, it's very useful for me. I've found a crash when somebody sets as option compat: false and doesn't specify defaultFilterRole or specify 'nofilter'.

As we can see on filter.js file, _getFilterKeys method:
var filter = {nofilter: null};

nofilter value is null, for that reason it crashes later on getReadFilterKeys method when:

filters.join(' ');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant