replace test_zypper_dup_works with test_no_downgrade_on_install #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmueller
force-pushed
the
no_downgrade
branch
from
7bc3ac5 to
c48159d
Compare
dcermak
reviewed
Oct 23, 2023
| continue | ||
| for req in solvable.get("solvable:requires", ()): | ||
| # Skip boolean dependencies or unversioned ones | ||
| if "(" in req or " = " not in req: |
There was a problem hiding this comment.
This will also skip virtual requires like pkgconfig(libfoo) = 1.2.3.
There was a problem hiding this comment.
@dcermak yeah, I didn't want to implement provides/requires matching logic. so far it was finding the essential issues without that (as typically people do Requires: %name = %version-%release somewhere. we can always improve that later if it is necessary to find more issues (but already now it finds too many :/ )
dirkmueller
force-pushed
the
no_downgrade
branch
3 times, most recently
from
e4add9e to
2543ace
Compare
dcermak
reviewed
Oct 25, 2023
dirkmueller
force-pushed
the
no_downgrade
branch
from
f85ea77 to
80829d9
Compare
grisu48
reviewed
Oct 25, 2023
dirkmueller
force-pushed
the
no_downgrade
branch
7 times, most recently
from
233622d to
3c99a3d
Compare
dirkmueller
force-pushed
the
no_downgrade
branch
from
3c99a3d to
64126dd
Compare
grisu48
previously approved these changes
Oct 30, 2023
dirkmueller
force-pushed
the
no_downgrade
branch
from
64126dd to
17d3305
Compare
test_zypper_dup is a bit too agressive and on the other side misses cases. so we just validate that installing any of the additional packages would not cause a downgrade in the container.
dirkmueller
force-pushed
the
no_downgrade
branch
from
17d3305 to
b2401ef
Compare
mgrossu
approved these changes
Jan 23, 2024
rcmadhankumar
pushed a commit
that referenced
this pull request
Aug 30, 2024
replace test_zypper_dup_works with test_no_downgrade_on_install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_zypper_dup is a bit too agressive and on the other side misses cases. so we just validate that installing any of the additional packages would not cause a downgrade in the container.