Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke tests for stunnel #688

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add smoke tests for stunnel #688

wants to merge 1 commit into from

Conversation

dcermak
Copy link
Collaborator

@dcermak dcermak commented Dec 5, 2024

[CI:TOXENVS] stunnel

for SUSE/BCI-dockerfile-generator#2110

@dcermak dcermak marked this pull request as ready for review December 5, 2024 15:25
Copy link
Member

@alexandrevicenzi alexandrevicenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but it needs a rebase.

return resp

resp = get_request_to_stunnel()
assert resp.status_code >= 300 and resp.status_code < 400
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: to be more precise, it returns a 301 code, this range allows multiple statuses, it very unlikely to change on the Wikipedia side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants