Refresh entity detail and schema detail on update #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeodoraPavlova
changed the title
crazyscientist
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
I believe I understand what you meant in yesterday's standup.
The fact that we need to call getSelected after this.selected was modified by getSelected, onSelect or onClear (indirectly via triggering a change of the modelValue param) looks superfluous.
To avoid such suboptimal solutions we would need a large scale review and refactoring of the UI, which clearly is out of scope of #178.
Thank you for finding this simple fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #178
Applied fixes for:
When you edit an entity/attributes in entity detail page and you click save, the values of attributes of type FK are vanishing. Previously manual page reload showed them again and now it's not needed.
If you go back from entity detail page to schema details, entity list is not refreshed. Now it is.