Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Fixed editorial comments.

Co-authored-by: Daria Vladykina <[email protected]>
  • Loading branch information
harneshalaka and dariavladykina authored Dec 19, 2024
1 parent 3387790 commit 40a385d
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions tasks/networkmanager-nmcli-configure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ connection, run the command:</para>
<title>Requirements</title>
<listitem>
<para>Install the <literal>teamd</literal> and <literal>NetworkManager-team</literal> packages:</para>
<screen>&prompt.sudo; zypper install teamd
&prompt.sudo; zypper install NetworkManager-team</screen>
<screen>&prompt.sudo; zypper install teamd
&prompt.sudo; zypper install NetworkManager-team</screen>
</listitem>
<listitem>
<para>Install two or more physical or virtual devices on the server:</para>
Expand All @@ -212,15 +212,15 @@ connection, run the command:</para>
</para>
</listitem>
<listitem>
<para>To use bond, bridge, or VLAN devices as ports of the team, you can either create these devices while you create the team or you can create them in advance.</para>
<para>To use bond, bridge or VLAN devices as ports of the team, you can either create these devices while you create the team or you can create them in advance.</para>
</listitem>
</itemizedlist>
<procedure>
<title>Creating network team</title>
<title>Creating a network team</title>
<step><para>Create a team interface:</para>
<screen>nmcli connection add type team con-name team0 ifname team0 team.runner activebackup</screen>
<para>
A network team, <literal>team0</literal> that uses the <literal>activebackup</literal> runner is created.
A network team, <literal>team0</literal>, that uses the <literal>activebackup</literal> runner, is created.
</para>
</step>
<step>
Expand All @@ -234,25 +234,27 @@ connection, run the command:</para>
eth0 ethernet unavailable --
lo loopback unmanaged --
</screen>
<para>The list of available network interfaces appear. You can add the interfaces to the team. In the given list, <literal>p2p-dev-wlan0</literal>, is not configured and <literal>virbr0</literal> is configured and have connection profile.
<para>The list of available network interfaces appears. You can add the interfaces to the team. In the given list, <literal>p2p-dev-wlan0</literal> is not configured, while <literal>virbr0</literal> is configured and has a connection profile.
</para>
</step>
<step><para>Configure port interfaces to the team:</para>
<screen>nmcli connection add type wifi-p2p slave-type team con-name team0-port1 ifname p2p-dev-wlan0 master team0</screen>
<para>A new profile is created for <literal>p2p-dev-wlan0</literal> and added to the <literal>bond0</literal> connection.</para></step>
<step><para>Assign existing connection to the team:</para>
<step><para>Assign the existing connection to the team:</para>
<screen>nmcli connection modify bond0 master team0</screen>
<para>The connection profile for <literal>bond0</literal> is added to the <literal>team0</literal> connection.</para>
</step>
<step><para>Activate the connection:</para>
<screen>nmcli connection up bond0</screen></step>
<step><para>Configure the IPv4 settings:</para>
<substeps><step><para>To use the team device as port of other devices:</para>
<substeps><step><para>To use the team device as a port of other devices:</para>
<screen>nmcli connection modify team0 ipv4.method disabled</screen>
</step>
<step><para>To use DHCP, no configuration is required.
</para></step>
<step><para>To configure static IPv4 address, network mask, default gateway, and DNS server to the <literal>bond0</literal> connection, run the command:</para>
<step><para>To configure a static IPv4 address, network mask,
default gateway and DNS server to the <literal>bond0</literal>
connection, run the command:</para>
<screen>nmcli connection modify team0 ipv4.addresses '192.0.2.1/24' ipv4.gateway '192.0.2.254' ipv4.dns '192.0.2.253' ipv4.dns-search 'example.com' ipv4.method manual</screen>
</step>
</substeps>
Expand All @@ -262,7 +264,7 @@ connection, run the command:</para>
<screen>nmcli connection modify team0 ipv6.method disabled</screen>
</step>
<step><para>To use stateless address autoconfiguration (SLAAC), no action is required. </para></step>
<step><para>To set a static IPv6 address, network mask, default gateway, and DNS server to the <literal>team0</literal> connection, enter:</para>
<step><para>To set a static IPv6 address, network mask, default gateway and DNS server to the <literal>team0</literal> connection, enter:</para>
<screen>nmcli connection modify team0 ipv6.addresses '2001:db8:1::1/64' ipv6.gateway '2001:db8:1::fffe' ipv6.dns '2001:db8:1::fffd' ipv6.dns-search 'example.com' ipv6.method manual
</screen>
</step>
Expand All @@ -277,7 +279,7 @@ connection, run the command:</para>
</section>
<section xml:id="configure-network-bridge">
<title>Configuring a network bridge</title>
<para>To configure network bridge, ensure the following:</para>
<para>To configure a network bridge, ensure the following:</para>
<itemizedlist>
<listitem>
<para>Install two or more physical or virtual devices on the server.</para>
Expand Down

0 comments on commit 40a385d

Please sign in to comment.