Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rails 2.19.1 → 2.20.2 (minor) #1287

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jun 20, 2023

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.19.1 → 2.20.2) · Repo · Changelog

Release Notes

2.20.2

Bug fixes

  • #1028: Fix an error for Rails/UniqueValidationWithoutIndex when the presence: true option is used alone for the validates method. (@koic)

2.20.1

Bug fixes

  • #1021: Fix an error for Rails/UniqueValidationWithoutIndex. (@ydah)

2.20.0

New features

Bug fixes

  • #1005: Flag break in with_lock for Rails/TransactionExitStatement. (@splattael)
  • #997: Fix to Allow NotNullColumn to work with method calls and variables. (@fidalgo)
  • #989: Fix Rails/FilePath to detect offenses from complex string interpolation. (@r7kamura)
  • #1010: Fix Rails/ThreeStateBooleanColumn for dynamic tables/columns. (@fatkodima)
  • #1008: Fix UniqueValidationWithoutIndex to not detect offenses when a validation specifies uniqueness: false. (@samrjenkins)

Changes

  • #1011: Add *_create_active_storage_variant_records.active_storage.rb to Rails/CreateTableWithTimestamps exclude file list. (@tka5)
  • #995: Check for or method in Rails/FindEach cop. (@masato-bkn)
  • #1019: Change db migration file pattern so that it supports multiple db. (@r7kamura)
  • #986: (Breaking) Drop Ruby 2.6 support. (@koic)
  • #992: Exclude app/assets/**/* by default. (@r7kamura)
  • #1014: Make Lint/RedundantSafeNavigation aware of presence and present? methods. (@koic)
  • #1007: Support flash.now for Rails/I18nLocaleTexts. (@fatkodima)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 56 commits:

✳️ rubocop (1.51.0 → 1.54.1) · Repo · Changelog

Release Notes

1.54.0

New features

  • #12000: Support safe or unsafe autocorrect config for LSP. (@koic)

Bug fixes

  • #12005: Fix a false negative for Lint/Debugger when using debugger method inside lambda. (@koic)
  • #11986: Fix a false positive for Lint/MixedCaseRange when the number of characters at the start or end of range is other than 1. (@koic)
  • #11992: Fix an unexpected NoMethodError for built-in language server when an internal error occurs. (@koic)
  • #11994: Fix an error for Layout/LineEndStringConcatenationIndentation when inspecting the % from string %\n\n. (@koic)
  • #12007: Fix an error for Layout/SpaceAroundOperators when using unary operator with double colon. (@koic)
  • #11996: Fix an error for Style/IfWithSemicolon when without branch bodies. (@koic)
  • #12009: Fix an error for Style/YodaCondition when equality check method is used without the first argument. (@koic)
  • #11998: Fix an error when inspecting blank heredoc delimiter. (@koic)
  • #11989: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using unicode chars. (@koic)
  • #12001: Fix code length calculator for method calls with heredoc. (@fatkodima)
  • #12002: Fix Lint/Void cop for __ENCODING__ constant. (@fatkodima)

Changes

  • #11983: Add Ridgepole files to default Include list. (@ydah)
  • #11738: Enhances empty_line_between_defs to treat configured macros like defs. (@catwomey)

1.53.1

Bug fixes

  • #11974: Fix an error for Style/RedundantCurrentDirectoryInPath when using string interpolation in require_relative. (@koic)
  • #11981: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using double quote and single quote characters. (@koic)
  • #11836: Should not offense single-quoted symbol containing double quotes in Lint/SymbolConversion . (@KessaPassa)

1.53.0

New features

Bug fixes

  • #11953: Fix a false negative for Lint/DuplicateHashKey when there is a duplicated constant key in the hash literal. (@koic)
  • #11945: Fix a false negative for Style/RedundantSelfAssignmentBranch when using method chaining or arguments in ternary branch. (@koic)
  • #11949: Fix a false positive for Layout/RedundantLineBreak when using a line broken string. (@koic)
  • #11931: Fix a false positive for Lint/RedundantRequireStatement when using PP.pp. (@koic)
  • #11946: Fix an error for Lint/NumberConversion when using multiple number conversion methods. (@koic)
  • #11972: Fix an error for Lint/Void when CheckForMethodsWithNoSideEffects: true and using a method definition. (@koic)
  • #11958: Fix error for Style/IdenticalConditionalBranches when using empty parentheses in the if branch. (@koic)
  • #11962: Fix an error for Style/RedundantStringEscape when an escaped double quote precedes interpolation in a symbol literal. (@koic)
  • #11947: Fix an error for Style/ConditionalAssignment with an assignment that uses if branch bodies, which include a block. (@koic)
  • #11959: Fix false negatives for Layout/EmptyLinesAroundExceptionHandlingKeywords when using Ruby 2.5's rescue inside block and Ruby 2.7's numbered block. (@koic)
  • #10902: Fix an error for Style/RedundantRegexpEscape string with invalid byte sequence in UTF-8. (@ydah)
  • #11562: Fixed escaped octal handling and detection in Lint/DuplicateRegexpCharacterClassElement. (@rwstauner)

Changes

  • #11904: Mark Layout/ClassStructure as unsafe to autocorrect. (@nevans)
  • #8506: Add AllowedParentClasses config to Lint/MissingSuper. (@iMacTia)

1.52.1

Bug fixes

  • #11944: Fix an incorrect autocorrect for Style/SoleNestedConditional with Style/MethodCallWithArgsParentheses. (@koic)
  • #11930: Fix exception on Lint/InheritException when class definition has non-constant siblings. (@rafaelfranca)
  • #11919: Fix an error for Lint/UselessAssignment when a variable is assigned and unreferenced in for. (@koic)
  • #11928: Fix an incorrect autocorrect for Lint/AmbiguousBlockAssociation. (@koic)
  • #11915: Fix a false positive for Lint/RedundantSafeNavigation when &. is used for to_s, to_i, to_d, and other coercion methods. (@lucthev)

Changes

1.52.0

New features

  • #11873: Add ComparisonsThreshold config option to Style/MultipleComparison. (@fatkodima)
  • #11886: Add new Style/RedundantArrayConstructor cop. (@koic)
  • #11873: Add new Style/RedundantRegexpConstructor cop. (@koic)
  • #11841: Add new Style/RedundantFilterChain cop. (@fatkodima)
  • #11908: Support AllowedReceivers for Style/CollectionMethods. (@koic)

Bug fixes

  • #11890: Fix a false negative for Lint/RedundantSafeNavigation when &. is used for to_d. (@koic)
  • #11880: Fix a false positive for Style/ExactRegexpMatch when using literal with quantifier in regexp. (@koic)
  • #11902: Fix a false positive for Style/RequireOrder when single-quoted string and double-quoted string are mixed. (@koic)
  • #11879: Fix a false positive for Style/SelectByRegexp when Ruby 2.2 or lower analysis. (@koic)
  • #11891: Fix Style/AccessorGrouping to accept macros separated from accessors by space. (@fatkodima)
  • #11905: Fix an error for Lint/UselessAssignment when a variable is assigned with rest assignment and unreferenced. (@koic)
  • #11899: Fix an incorrect autocorrect for Style/SingleLineMethods when using Ruby 3.0 and Style/EndlessMethod is disabled. (@koic)
  • #11884: Make rubocop -V display rubocop-factory_bot version when using it. (@koic)
  • #11893: Fix a false positive for Lint/InheritException when inheriting Exception with omitted namespace. (@koic)
  • #11898: Fix offences in calls inside blocks with braces for Style/MethodCallWithArgsParentheses with omit_parentheses enforced style. (@gsamokovarov)
  • #11857: Server mode: only read $stdin when -s or --stdin argument provided. (@naveg)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

🆕 language_server-protocol (added, 3.17.0.3)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jun 20, 2023
@depfu depfu bot force-pushed the depfu/update/rubocop-rails-2.20.2 branch from 9ae0f90 to 1d4f0aa Compare July 4, 2023 09:31
@hennevogel hennevogel force-pushed the depfu/update/rubocop-rails-2.20.2 branch from 1d4f0aa to fd6eade Compare August 11, 2023 14:17
@hennevogel hennevogel force-pushed the depfu/update/rubocop-rails-2.20.2 branch from 135d7db to fa8f7f6 Compare August 11, 2023 14:26
@hennevogel hennevogel merged commit 155d6f2 into master Aug 11, 2023
2 checks passed
@depfu depfu bot deleted the depfu/update/rubocop-rails-2.20.2 branch August 11, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant