Simplify markdown preview #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hennevogel
commented
Sep 23, 2024
•
hennevogel
commented
- Do not let unauthenticated people render a markdown preview
- Remove Haml::Filters monkey patch, it just replaces some text. Do that in a MarkdownHelper instead.
- Do not render markdown with MarkdownHelper, use a haml partial instead
There is no need to have this in the markdown source...
hennevogel
force-pushed
the
refactoring/md-parsing
branch
2 times, most recently
from
b3893e3
to
5f9f7f6
Compare
- Do not let unauthenticated people render a markdown preview - Remove Haml::Filters monkey patch, it just replaces some text. Do that in a MarkdownHelper instead. - Do not render markdown with MarkdownHelper, use a haml partial instead
hennevogel
force-pushed
the
refactoring/md-parsing
branch
from
5f9f7f6
to
2ec436d
Compare
danidoni
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.