Add AI model demo Helm chart and Rancher prime installation script #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devpro
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Could you make the related changes?
- template files must follow conventions (no need for ai-model prefix)
- ai-model Helm chart name is too general, needs to be more explicit/specific
- README.md file in Helm chart (at least to explain what is the purpose of the chart)
- use more variables in Helm charts
- Mackroservices is mentioned in Helm chart file but what is Mackroservices?
|
@devpro This is purely a demo workload that is autogenerated. It doesn't contain any working code, just a mocked up service for observability purposes. It's part of the demo flow that we need to demo on rancher day |
devpro
reviewed
Nov 5, 2024
| kind: Ingress | ||
| metadata: | ||
| annotations: | ||
| cert-manager.io/cluster-issuer: letsencrypt-prod |
There was a problem hiding this comment.
Cannot be hard coded like this
Annotations must come from values file (look at other chart for examples)
devpro
changed the title
Signed-off-by: Jeroen van Erp <[email protected]>
Signed-off-by: Jeroen van Erp <[email protected]>
Signed-off-by: Jeroen van Erp <[email protected]>
Signed-off-by: Jeroen van Erp <[email protected]>
Signed-off-by: Jeroen van Erp <[email protected]>
Signed-off-by: Jeroen van Erp <[email protected]>
Signed-off-by: Jeroen van Erp <[email protected]>
Signed-off-by: Jeroen van Erp <[email protected]>
Signed-off-by: Jeroen van Erp <[email protected]>
Signed-off-by: Jeroen van Erp <[email protected]>
Signed-off-by: Jeroen van Erp <[email protected]>
Signed-off-by: Jeroen van Erp <[email protected]>
Signed-off-by: Jeroen van Erp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.