Skip to content

Commit

Permalink
Merge pull request #304 from ricardobranco777/fixit
Browse files Browse the repository at this point in the history
More fixes
  • Loading branch information
asmorodskyi authored Aug 31, 2023
2 parents 6b39d20 + 01e991d commit 1759a6b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
3 changes: 1 addition & 2 deletions ocw/lib/ec2.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,7 @@ def delete_vpc_subnets(self, vpc) -> None:
if exc.response['Error']['Code'] == 'InvalidParameterValue':
self.log_info(exc.response['Error'])
continue
else:
raise
raise
if self.dry_run:
self.log_info(f'Deletion of {subnet} skipped due to dry_run mode')
else:
Expand Down
3 changes: 1 addition & 2 deletions ocw/lib/gce.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ def list_zones(self, region) -> list:
if GCE.get_error_reason(exc) == 'notFound':
self.log_dbg("list_zones: region {} not found", region)
return []
else:
raise exc
raise exc

def delete_instance(self, instance_id, zone) -> None:
self._delete_resource(
Expand Down
1 change: 0 additions & 1 deletion ocw/lib/openstack.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ def client(self) -> None:
if self.__client is None:
self.__client = openstack.connect(
debug=bool(DEBUG),
insecure=True, # Trust the certificate
auth_url=self.get_data('auth_url'),
project_name=self.get_data('project_name'),
username=self.get_data('username'),
Expand Down

0 comments on commit 1759a6b

Please sign in to comment.