Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Dockerfile_k8s_dev #286

Merged

Conversation

pdostal
Copy link
Collaborator

@pdostal pdostal commented Aug 1, 2023

No description provided.

Copy link
Collaborator

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardobranco777 ricardobranco777 merged commit 595a205 into SUSE:master Aug 1, 2023
6 of 8 checks passed
@asmorodskyi
Copy link
Collaborator

please don't merge PRs with failed tests , this should be hard rule

@asmorodskyi
Copy link
Collaborator

ok I created a rule for master branch which will disable such ability ....

@ricardobranco777
Copy link
Collaborator

please don't merge PRs with failed tests , this should be hard rule

In this case it was failing because the Selenium test was failing (reason: updated Selenium package).

I should have merged my PR fixing it first and told Pavel to rebase this one.

@ricardobranco777
Copy link
Collaborator

ok I created a rule for master branch which will disable such ability ....

What will happen in the case of codecov failing?

@asmorodskyi
Copy link
Collaborator

please don't merge PRs with failed tests , this should be hard rule

In this case it was failing because the Selenium test was failing (reason: updated Selenium package).

I should have merged my PR fixing it first and told Pavel to rebase this one.

yes I get that part that Pavel's PR does not introduce the problem , but from my POV it does not change anything . When tests are failing repo considered as "broken" and should be fixed before anything else will be merged into it

@asmorodskyi
Copy link
Collaborator

ok I created a rule for master branch which will disable such ability ....

What will happen in the case of codecov failing?

  1. Make codecov not to fail , and this can be achieved in two ways :
    - relax failure conditions ( e.g. if test currently failing because we don't achieve coverage 75% than we set it to fail when we not achieve coverage 70% )
    - make it not to fail in "natural way" :)
  2. Disable codecov pipeline full

All in all having something which is constantly failing and we ignore this it is bad practice and should be avoided as much as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants