Add wheel package to all containers #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 78.81% 79.10% +0.29%
==========================================
Files 21 21
Lines 1614 1613 -1
==========================================
+ Hits 1272 1276 +4
+ Misses 342 337 -5
☔ View full report in Codecov by Sentry. |
asmorodskyi
force-pushed
the
next3
branch
3 times, most recently
from
e1cc6db
to
ce702aa
Compare
asmorodskyi
force-pushed
the
next3
branch
2 times, most recently
from
b503b4a
to
9cb2a78
Compare
ricardobranco777
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Great refactoring!
I will take a look at https://pypi.org/project/requests-mock/ on a side project and then perhaps reuse here.
LGTM
| # returns "compute#route" for all routes. | ||
| # All this creating false alarms in log which we want to prevent. | ||
| # Only way to prevent is mute error | ||
| if resource_type.title() == "Route" and "The local route cannot be deleted" in str(err): |
There was a problem hiding this comment.
Why use .title() here?
There was a problem hiding this comment.
I don't know I was just copy/paste this from your code above :) returning question back to you :)
There was a problem hiding this comment.
I don't remember XD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.