Check for SLE Micro and SUMa headers to grant access #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUMA 5.0 is based on SLE Micro, to access older SUMA versions we are using new headers present in the request to grant access to SUMA 4.X repositories
jesusbv
force-pushed
the
suma-access-micro
branch
from
c88f431
to
4064c1e
Compare
rjschwei
reviewed
Nov 14, 2024
| # SUMA 5.0 must have access to SUMA 4.3, 4.2 and so on | ||
| micro = p.identifier.downcase.include?('sle-micro') | ||
| instance_id_header = headers.fetch('X-Instance-Identifier', '').casecmp('suse-manager-server').zero? | ||
| instance_version_header = headers.fetch('X-Instance-Version', '') == '5.0' |
There was a problem hiding this comment.
@rjmateus will SUMa always send the 5.0 version identifier even when we move to 5.1, 5.2 etc.?
There was a problem hiding this comment.
I think we should/will send in future the real suma version. So yes, 5.1, 5.2, ... might be there.
There was a problem hiding this comment.
As Michael said, that is the goal. I even change the version to 5.1 in our upstream project.
There was a problem hiding this comment.
@jesusbv per comment from SUMa team the version check needs to be different, could be a > check.
rjschwei
approved these changes
Nov 14, 2024
rjschwei
requested changes
Nov 14, 2024
| # SUMA 5.0 must have access to SUMA 4.3, 4.2 and so on | ||
| micro = p.identifier.downcase.include?('sle-micro') | ||
| instance_id_header = headers.fetch('X-Instance-Identifier', '').casecmp('suse-manager-server').zero? | ||
| instance_version_header = headers.fetch('X-Instance-Version', '') == '5.0' |
There was a problem hiding this comment.
@jesusbv per comment from SUMa team the version check needs to be different, could be a > check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SUMA 5.0 is based on SLE Micro, to access older SUMA versions we are using new headers present in the request to grant access to SUMA 4.X repositories
How to test
Activate SUMA 4.3 from SUMA 5.0 UI, it should get access to SUMA 4.3
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Review
Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.