Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursors, Esc to cancel active tool #946

Merged
merged 7 commits into from
Jan 17, 2024
Merged

Conversation

olekhshch
Copy link
Contributor

PR description

-- more specific cursors for Circle, Ellipse, Square and Rectangle tools

-- Esc key cancels the currently selected tool. It applies only for Zoom, Rect, Square, Circle, Ellipse, Line, Text, Star, Polygon, and Eyedropper. Cancelation with the Esc key is disabled if pressed in the middle of using those tools (e.g. in the middle of drawing a new circle) to avoid unexpected behaviour;

-- I and B shortcuts for italic and bold text are unavailable if no text element is selected - currently, when pressing those keys nothing happens and other shortcuts (e.g. E for Ellipse) become unavailable until refresh (app throws an error);

-- minor styling changes

@olekhshch olekhshch changed the title Cursor Cursors, Esc to cancel active tool Jan 15, 2024
@jfhenon
Copy link
Collaborator

jfhenon commented Jan 16, 2024

please fix linter issues.

@olekhshch
Copy link
Contributor Author

Sorry, my bad, I accidentally ran the linter on the wrong branch before submitting PR 😅 Fixed

would be nice to find out a replacement or a fix
@jfhenon jfhenon merged commit f75d1a8 into SVG-Edit:master Jan 17, 2024
5 checks passed
@jfhenon
Copy link
Collaborator

jfhenon commented Jan 17, 2024

Brilliant - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants