[feat] 선물 토너먼트 점수 입력 API & 토너먼트 정보 조회 API 구현 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziiyouth
requested changes
Jan 12, 2024
There was a problem hiding this comment.
토너먼트 점수 변경할 때 (결과 API) roommember 테이블에 있는 토너먼트 참여 여부도 변경해줘야 할 것 같아요! 기본값 false(DB에는 tinyint 라서 0, 1)로 되어 있는 걸 true로 반환해줘야 토너먼트 완료한 사람 수 보내줄 수 있을 거 같습니다!
| @@ -142,4 +147,28 @@ private List<TournamentListsResponseDto> mapGiftsToTournamentLists(List<Gift> gi | |||
| .collect(Collectors.toList()); | |||
| } | |||
|
|
|||
| public void evaluateTournamentScore(TournamentScoreRequestDto tournamentScoreRequestDto) { | |||
| int firstPlaceScore = 10; | |||
There was a problem hiding this comment.
이런 상수 값은 private static final int FIRST_PLACE_SCORE = 10; 처럼 service단 맨 위에 고정으로 넣어주고 아래서는 FIRST_PLACE_SCORE로 꺼내와서 사용해도 유지보수에 용이할 것 같습니다 ㅎㅎ
hysong4u
changed the title
ziiyouth
reviewed
Jan 12, 2024
| @@ -36,6 +39,8 @@ public class GiftService { | |||
| private final RoomRepository roomRepository; | |||
| private final RoomMemberRepository roomMemberRepository; | |||
| private static final int MAX_GIFT_COUNT = 2; | |||
| private static final int FirstPlaceScore = 10; | |||
There was a problem hiding this comment.
여기서는 final로 상수를 정의한 거니까 두 가지 변수 명만 규칙에 맞게 대문자로 바꿔주면 좋을 거 같아요!!!
FIRST_PLACE_SCORE 처럼 적어주면 좋을 거 같아요 ~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 🍫
Summary 🍪
Before i request PR review 🍰