Fix for unyt 2.9.3 change in behaviour #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of comparison of an element of a dimensionless unyt_array to an integer changed in unyt 2.9.3, so avoid doing that!
|
I think that this is a bug in unyt. But we should check with unyt 3.0.0 |
|
It is. But we agreed we should program defensively against their stuff.... Also we need this to work now. |
|
I mean it is fixed in 2.9.4 right? |
|
However, I think actually doing this conversion to values when comparing against zero is probably a good practice anyway. |
MatthieuSchaller
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each halo we store a dict of unyt_quantities with the ID, position, search radius etc of the halo. This includes a flag to indicate if a halo has been processed.
In several places SOAP checks if the flag is set by comparing with 0. In unyt 2.9.3 the comparison always returns False and causes us to read zero cells from the snapshot and crash (see #6). This pull request modifies the code so that it's not sensitive to the changed behaviour.