M3-117 개인전 픽셀 가져오는 API 구현 완료 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koomin1227
approved these changes
Jun 22, 2024
| @RestController | ||
| @RequiredArgsConstructor | ||
| @RequestMapping("/api/pixels") |
There was a problem hiding this comment.
개인 픽셀이랑 경쟁 픽셀이랑 구분하기 위해 엔드포인트에 구분자가 필요할 것 같네요..
| private final PixelRepository pixelRepository; | ||
|
|
||
| public List<IndividualPixelResponse> getNearIndividualPixels(int currentX, int currentY, int xRange, int yRange) { |
There was a problem hiding this comment.
개인 픽셀과 경쟁 픽셀을 조회 하는 구분이 필요할 것 같아요
There was a problem hiding this comment.
생각하지 못했던 구분이였네요.. 추후 동적 쿼리나 컨트롤러 단에 구분자 추가 등으로 적용하겠습니다.
qjvk2880
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용*
고민한 내용*
리뷰 요구사항