M3-238 앱 버전 api #63
Merged
M3-238 앱 버전 api #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkdals802
requested review from
qjvk2880 and
koomin1227
and removed request for
qjvk2880
📝 테스트 커버리지 리포트
|
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
koomin1227
approved these changes
Aug 11, 2024
Comment on lines
26
to
34
| @Operation(summary = "앱 버전 post", description = "현재 앱 버전을 등록한다.") | ||
| @PostMapping("/version") | ||
| public Response<?> postVersion( | ||
| @Parameter(description = "버전 저장", required = true) | ||
| @RequestBody VersionRequest versionRequest | ||
| ) { | ||
| versionService.postVersion(versionRequest); | ||
| return Response.createSuccessWithNoData(); | ||
| } |
There was a problem hiding this comment.
시큐리티 적용없이 뚫려있는데 아무나 버전 바꾸면 어떻게되나요?
qjvk2880
approved these changes
Aug 11, 2024
koomin1227
requested changes
Aug 11, 2024
koomin1227
approved these changes
Aug 13, 2024
Comment on lines
1
to
18
| package com.m3pro.groundflip.domain.dto.version; | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
| import lombok.AllArgsConstructor; | ||
| import lombok.Builder; | ||
| import lombok.Data; | ||
| import lombok.NoArgsConstructor; | ||
|
|
||
| @Data | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| @Builder | ||
| @Schema(title = "앱 버전 등록") | ||
| public class VersionRequest { | ||
| @Schema(description = "앱 버전", example = "1.0.1") | ||
| private String version; | ||
|
|
||
| } |
| public class VersionController { | ||
| private final VersionService versionService; | ||
|
|
||
| @Operation(summary = "앱 버전 get", description = "현재 앱 버전을 가져온다.") |
There was a problem hiding this comment.
앱 버전 get 말고 "업데이트 여부 확인" 같은 표현으로 바꾸는게 좋을 것 같네요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용*
고민한 내용*
리뷰 요구사항