Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용*
고민한 내용*
리팩토링
RankingRedisRepository 를 리팩토링 했다. 기존에는
UserRankingRedisRepository
와CommunityRankingRedisRepository
가 sorted set 의 키값만 다르고 완전히 동일한 코드를 사용하고 있어 코드가 너무 많이 중복되었다.때문에 중복된 로직을 RankingRedisRepository 로 묶고 sorted set 의 키값을 생성자로 받아 각각의 도메인에 대해 다른 키값을 가지는 Repository 객체를 생성할 수 있게 리팩토링 했다.
리뷰 요구사항
스크린샷