Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3-349 그룹전 픽셀 상세 정보 반환 api 구현 #77

Merged
merged 12 commits into from
Sep 11, 2024

Conversation

koomin1227
Copy link
Member

작업 내용*

  • 픽셀의 상세 정보를 반환하는 api 구현

고민한 내용*

리팩토링

RankingRedisRepository 를 리팩토링 했다. 기존에는 UserRankingRedisRepositoryCommunityRankingRedisRepository 가 sorted set 의 키값만 다르고 완전히 동일한 코드를 사용하고 있어 코드가 너무 많이 중복되었다.
때문에 중복된 로직을 RankingRedisRepository 로 묶고 sorted set 의 키값을 생성자로 받아 각각의 도메인에 대해 다른 키값을 가지는 Repository 객체를 생성할 수 있게 리팩토링 했다.

public class RankingRedisRepository {
	private static final int RANKING_START_INDEX = 0;
	private static final int RANKING_END_INDEX = 29;
	private final String currentPixelRankingKey;
	private final String accumulatePixelRankingKey;
	private final RedisTemplate<String, String> redisTemplate;
	private ZSetOperations<String, String> zSetOperations;

	public RankingRedisRepository(RedisTemplate<String, String> redisTemplate, String currentPixelRankingKey,
		String accumulatePixelRankingKey) {
		this.redisTemplate = redisTemplate;
		this.currentPixelRankingKey = currentPixelRankingKey;
		this.accumulatePixelRankingKey = accumulatePixelRankingKey;
	}
}

리뷰 요구사항

  • 리뷰할 때 중점적으로 봐줬으면 하는 내용들

스크린샷

Copy link

📝 테스트 커버리지 리포트

Overall Project 74.76% -2.89% 🍏
Files changed 73.99%

File Coverage
CommunityRankingRedisRepository.java 100% 🍏
UserRankingRedisRepository.java 100% 🍏
CommunityRankingService.java 95.5% 🍏
UserRankingService.java 94.46% 🍏
RankingRedisRepository.java 92.7% -7.3% 🍏
PixelReader.java 52.92% -25.43%
PixelController.java 20.31% -9.38%

@koomin1227 koomin1227 merged commit 56f0dc2 into develop Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants