Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3-128 그룹 검색 화면 만들기 #10

Merged
merged 12 commits into from
Jun 27, 2024

Conversation

tkdals802
Copy link
Contributor

@tkdals802 tkdals802 commented Jun 27, 2024

작업 내용*

  • 상단 앱 바에 검색 텍스트바, 버튼 생성
  • 검색 결과를 보여주는 리스트 생성

고민한 내용*

  • 디자인이 변경될 것이기 때문에 디자인은 고려하지 않음
  • 현재 검색 창으로 들어가는 루트가 없어서 그룹 화면에 그룹 검색 버튼을 생성하였다.

리뷰 요구사항

  • 함수, 클래스, 변수 이름

스크린샷

스크린1 스크린2

|
복사본1
|
복사본2
|

Copy link
Contributor

@qjvk2880 qjvk2880 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변수명 다 잘 지어졌고 코드도 깔끔하네요!!고생하셨습니다!!

Copy link
Member

@koomin1227 koomin1227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좀 컨플릭트가 나긴 했지만 그래도 잘 구현하셨네요!

@tkdals802 tkdals802 merged commit c7fdb4e into develop Jun 27, 2024
1 check passed
@tkdals802 tkdals802 deleted the feature/M3-128-searchGroupScreen branch June 27, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants