Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach and set up with WebClient Config #178

Merged
merged 18 commits into from
Nov 18, 2023
Merged

Conversation

inh2613
Copy link
Member

@inh2613 inh2613 commented Nov 18, 2023

PR Type

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 테스트 코드 작성
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 문서 작성

Motivation

기프티콘 자동 등록 요청 시, GPT 서버에 요청이 가기도 전에 recvAddress(..) failed: Connection reset by peer 에러가 발생하면서 끝나버림

Problem Solving

  1. WebClient Config로 분리하고 생성자 주입으로 사용되도록 개선
  2. WebClient에서 다양한 설정으로 에러나지 않도록 함
    • 참고
      • 유휴 커넥션을 일정 주기로 제거한다.
      • maxConnection을 늘린다.
      • lifo, 즉, 나중에 반환된 커넥션을 재사용하도록 한다. 이는 커넥션의 재사용률을 높인다.
      • retry를 설정한다.

To Reviewer

완벽하게 해결된 것은 아니지만, 기존보다는 개선되었다고 생각합니다!

@inh2613 inh2613 added the 🐛 bug Something isn't working label Nov 18, 2023
@inh2613 inh2613 self-assigned this Nov 18, 2023
Copy link
Member

@jinlee1703 jinlee1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@inh2613 inh2613 merged commit 4a6bb84 into develop Nov 18, 2023
2 checks passed
@inh2613 inh2613 deleted the fix/GH-466-connection-error branch November 18, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants