Fix max call stack exceeded for getHeight()

SabakiHQ · Mar 18, 2020 · 6331e41 · 6331e41
1 parent 10eed1d
commit 6331e41
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/GameTree.js b/src/GameTree.js
@@ -196,7 +196,16 @@ class GameTree {
 
   getHeight() {
     if (this._heightCache == null) {
-      let inner = node => 1 + Math.max(...node.children.map(inner), 0)
+      let inner = node => {
+        let max = 0
+
+        for (let child of node.children) {
+          max = Math.max(max, inner(child))
+        }
+
+        return max + 1
+      }
+
       this._heightCache = inner(this.root)
     }