Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORCA-294] Fix tox implementation in CI pipeline #31

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Dec 13, 2023

Problem:

Our CI pipeline is failing to test our code with the intended Python versions.

Solution:

Update ci.yml to use the tox-gh GH Actions plugin.

Notes:

  • After a discussion with @thomasyu888, we determined that for now, we will only support Python 3.10 and 3.11 in py-orca
    • The dependency issues with this repository and Python 3.8/3.9 have been very difficult to navigate, primarily because of apache-airflow.
    • Once ORCA-293 is complete, we will try to support Python 3.8 and 3.9 again if possible.
    • Although this is not ideal, it should not impact the use of py-orca much, as it is primarily used within orca-recipes, which uses Python 3.10 by default.
  • A GH Action run with these changes can be viewed here.
    • Please verify that the versions listed in the logs for the Run tests steps under tox:py match those expected before approving as a sanity check.

Copy link

swarmia bot commented Dec 13, 2023

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70964a9) 100.00% compared to head (3eb5983) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          920       920           
  Branches       140       140           
=========================================
  Hits           920       920           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@BWMac BWMac marked this pull request as ready for review December 14, 2023 21:18
Copy link
Collaborator

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! As discussed, there's another ticket to tackle the constraints issue

@BWMac BWMac merged commit 770c00f into main Dec 15, 2023
11 checks passed
@BWMac BWMac deleted the bwmac/ORCA-294/fix_tox branch December 15, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants