-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI testing #32
CI testing #32
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 920 920
Branches 140 140
=========================================
Hits 920 920 ☔ View full report in Codecov by Sentry. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look go to me. I was able to follow the contributing docs, run the shell script, and run pytest on the unit tests in a new environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Nice!
Problem:
Recently, our Airflow deployment has begun to fail when some un-constrained dependencies are updated. Our testing pipeline in
py-orca
has also begun to fail due to the same issue.Solution:
Update
py-orca
to use the constraints file provided by the airflow developers when installing dependencies.Notes:
pip
, I needed to remove our previouspipenv
setup.dev_setup.sh
script which creates a Python virtual environment, upgradespip
, installs airflow with its constraints, and installspy-orca
with all of its extras.requirements-airflow.txt
file as a dependency for thetestenv
section intox.ini
. This ensures that the required versions of airflow dependencies are installed in the Github Action runner.