Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI testing #32

Merged
merged 23 commits into from
Jan 10, 2024
Merged

CI testing #32

merged 23 commits into from
Jan 10, 2024

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Jan 3, 2024

Problem:

Recently, our Airflow deployment has begun to fail when some un-constrained dependencies are updated. Our testing pipeline in py-orca has also begun to fail due to the same issue.

Solution:

Update py-orca to use the constraints file provided by the airflow developers when installing dependencies.

Notes:

  • Because dependency constraints files are currently only supported in pip, I needed to remove our previous pipenv setup.
  • Development environment setup is now achieved by running the dev_setup.sh script which creates a Python virtual environment, upgrades pip, installs airflow with its constraints, and installs py-orca with all of its extras.
  • To use these constraints in our CI pipeline, I added the requirements-airflow.txt file as a dependency for the testenv section in tox.ini. This ensures that the required versions of airflow dependencies are installed in the Github Action runner.

Copy link

swarmia bot commented Jan 3, 2024

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (770c00f) 100.00% compared to head (aa974be) 100.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          920       920           
  Branches       140       140           
=========================================
  Hits           920       920           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@BWMac BWMac marked this pull request as ready for review January 8, 2024 21:10
@BWMac BWMac requested a review from a team as a code owner January 8, 2024 21:10
@BWMac BWMac requested a review from BryanFauble January 8, 2024 21:10
@BWMac BWMac requested a review from thomasyu888 January 8, 2024 21:10
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look go to me. I was able to follow the contributing docs, run the shell script, and run pytest on the unit tests in a new environment.

Copy link
Collaborator

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Nice!

@BWMac BWMac merged commit 04a94ee into main Jan 10, 2024
11 checks passed
@BWMac BWMac deleted the bwmac/orca-293/airflow-constraints branch January 10, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants